port_tree_model.cpp

Go to the documentation of this file.

#include "gui/selection_details_widget/module_details_widget/port_tree_model.h"
 
#include "gui/basic_tree_model/base_tree_item.h"
#include "gui/gui_globals.h"
#include "gui/python/py_code_provider.h"
#include "gui/user_action/action_pingroup.h"
#include "hal_core/netlist/endpoint.h"
#include "hal_core/netlist/gate.h"
#include "hal_core/netlist/module.h"
#include "hal_core/netlist/net.h"
#include "hal_core/utilities/enums.h"
 
#include <QDebug>
#include <QMimeData>
 
namespace hal
{
    PortTreeItem::PortTreeItem(Type itype, u32 id_, QString pinName, PinDirection dir, PinType ptype, int inx, QString netName)
        : mItemType(itype), mId(id_), mPinName(pinName), mPinDirection(dir), mPinType(ptype), mNetName(netName), mIndex(inx)
    {;}
 
    QVariant PortTreeItem::getData(int index) const
    {
        switch (index)
        {
        case 0:
            return mPinName;
        case 1:
            return QString::fromStdString(enum_to_string(mPinDirection));
        case 2:
            return QString::fromStdString(enum_to_string(mPinType));
        case 3:
            return mNetName;
        case 4:
            if (mItemType==PortTreeItem::Group)
                return ( mIndex ? "descending" : "ascending");
            return mIndex;
        }
        return QVariant();
    }
 
    void PortTreeItem::setData(QList<QVariant> data)
    {
        Q_ASSERT(data.size() >= 5);
        mPinName      = data[0].toString();
        mPinDirection = enum_from_string<PinDirection>(data[1].toString().toStdString());
        mPinType      = enum_from_string<PinType>(data[2].toString().toStdString());
        mNetName      = data[3].toString();
        mIndex        = data[4].toInt();
    }
 
    void PortTreeItem::setDataAtIndex(int index, QVariant &data)
    {
        switch (index)
        {
        case 0:
            mPinName = data.toString();
            break;
        case 1:
            mPinDirection = enum_from_string<PinDirection>(data.toString().toStdString());
            break;
        case 2:
            mPinType = enum_from_string<PinType>(data.toString().toStdString());
            break;
        case 3:
            mNetName = data.toString();
            break;
        case 4:
            mIndex = data.toInt();
            break;
        }
    }
 
    void PortTreeItem::appendData(QVariant data)
    {
        Q_UNUSED(data)
    }
 
    int PortTreeItem::getColumnCount() const
    {
        return 5;
    }
 
    ModulePinsTreeModel::ModulePinsTreeModel(QObject* parent) : BaseTreeModel(parent)
    {
        setHeaderLabels(QStringList() << "Name"
                                      << "Direction"
                                      << "Type"
                                      << "Connected Net"
                                      << "Index");
        setModule(gNetlist->get_module_by_id(1));
 
        //connections
        connect(gNetlistRelay, &NetlistRelay::modulePortsChanged, this, &ModulePinsTreeModel::handleModulePortsChanged);
    }
 
    ModulePinsTreeModel::~ModulePinsTreeModel()
    {
        delete mRootItem;
    }
 
    Qt::ItemFlags ModulePinsTreeModel::flags(const QModelIndex& index) const
    {
//        Qt::ItemFlags defaultFlags = BaseTreeModel::flags(index);
//        TreeItem* item             = index.isValid() ? getItemFromIndex(index) : nullptr;
//        if (item)
//        {
//            //get parent, must be a pingroup item and not the root (not allowed to drag from external group, but maybe later)
//            TreeItem* parentItem = item->getParent();
//            itemType type        = getTypeOfItem(item);
//            if (type == itemType::portMultiBit)
//                return defaultFlags | Qt::ItemIsDropEnabled;
//            else if (type == itemType::pin)                     // && parentItem != mRootItem)//only case that should be possible
//                return defaultFlags | Qt::ItemIsDragEnabled;    // | Qt::ItemIsDropEnabled;
//            if (parentItem == mRootItem && type == itemType::pin)
//                return defaultFlags;
//        }
        // valid-check must be ommitted when a drop between pingroups is desired, all checks are performed in canDropMimeData
        return BaseTreeModel::flags(index) | Qt::ItemIsDragEnabled | Qt::ItemIsDropEnabled;
//        if(item)
//        {
//            // everything can be dragged, but wether it can be dropped on or not depends on the situation
//            // -> a pin cannot be dropped onto its parent-group (but it can be dropped within its group),
//            // and a pingroup cannot be dropped onto (or between) a pin. -> what is currently dragged can only
//            // be checked in the "canDropMimeData" function, ItemIsDropEnabled cannot be set since its conditional on the dragged item
//            return defaultFlags | Qt::ItemIsDragEnabled | Qt::ItemIsDropEnabled;
 
//        }
//        return defaultFlags;
    }
 
    QStringList ModulePinsTreeModel::mimeTypes() const
    {
        QStringList types;
        types << "pintreemodel/item";
        return types;
    }
 
    QMimeData* ModulePinsTreeModel::mimeData(const QModelIndexList& indexes) const
    {
        if (indexes.size() != 5)    //columncount, only 1 item is allowed
            return new QMimeData();
 
        QMimeData* data = new QMimeData();
        PortTreeItem* item = static_cast<PortTreeItem*>(getItemFromIndex(indexes.at(0)));
        QByteArray encodedData;
        QDataStream stream(&encodedData, QIODevice::WriteOnly);
        QString type = item->itemType() == PortTreeItem::Pin ? "pin" : "group";
        stream << type << item->id();
        data->setText(item->itemType() == PortTreeItem::Pin
                        ? PyCodeProvider::pyCodeModulePinById(mModule->get_id(),item->id())
                        : PyCodeProvider::pyCodeModulePinGroup(mModule->get_id(),item->id()));
        data->setData("pintreemodel/item", encodedData);
        return data;
    }
 
    bool ModulePinsTreeModel::dropMimeData(const QMimeData* data, Qt::DropAction action, int row, int column, const QModelIndex& parent)
    {
        Q_UNUSED(action)
        Q_UNUSED(column)
 
        QString type;
        int id;
        QByteArray encItem = data->data("pintreemodel/item");
        QDataStream dataStream(&encItem, QIODevice::ReadOnly);
// debug pingroup        qDebug() << "dropMimeData" << encItem << row << column;
        dataStream >> type >> id;
 
        auto droppedItem = (type == "group") ?  static_cast<PortTreeItem*>(mIdToGroupItem.value(id)) :  static_cast<PortTreeItem*>(mIdToPinItem.value(id));
        //auto droppedParentItem = droppedItem->getParent();
        auto dropPositionItem = getItemFromIndex(parent);
 
        // perhaps helper functions?
        // 1. group on group (between group)
        // 2. pin on group
        // 3. pin between groups
        // 4. pin between pins
 
        // put ignore flags here? perhaps needed specifically in other places in functions..
 
        if(type == "group")
        {
            if(!dropPositionItem)
            {
// debug pingroup                qDebug() << "group was dropped between groups... with row: " << row; //check in canDropMine if its not an adjacent row?
                dndGroupBetweenGroup(droppedItem, row);
            }
            else
            {
                PortTreeItem* pitem = dynamic_cast<PortTreeItem*>(dropPositionItem);
                if (pitem && pitem->itemType() == PortTreeItem::Pin)
                {
                    // debug pingroup                qDebug() << "group was dropped on a pin...";
                    PortTreeItem* parentGroupItem = static_cast<PortTreeItem*>(pitem->getParent());
                    row = getIndexFromItem(pitem).row();
                    dndGroupOnGroup(droppedItem, parentGroupItem, row);
                }
                else
                    // debug pingroup                qDebug() << "group was dropped on a group?";
                    dndGroupOnGroup(droppedItem, dropPositionItem);
            }
        }
        else
        {
            if(!dropPositionItem)
            {
// debug pingroup                qDebug() << "pin was dropped between groups on row " << row;
                dndPinBetweenGroup(droppedItem, row);
            }
            else if(row != -1)
            {
// debug pingroup                qDebug() << "pin was dropped between pins";
                dndPinBetweenPin(droppedItem, dropPositionItem, row);
            }
            else
            {
                PortTreeItem* pitem = dynamic_cast<PortTreeItem*>(dropPositionItem);
                if (pitem && pitem->itemType() == PortTreeItem::Pin)
                {
// debug pingroup                qDebug() << "pin was dropped on a pin...";
                    PortTreeItem* parentGroupItem = static_cast<PortTreeItem*>(pitem->getParent());
                    row = getIndexFromItem(pitem).row();
                    dndPinBetweenPin(droppedItem, parentGroupItem, row);
                }
                else
// debug pingroup                qDebug() << "pin was dropped on a group...";
                    dndPinOnGroup(droppedItem, dropPositionItem);
            }
        }
 
        return true;
    }
 
 
    bool ModulePinsTreeModel::canDropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) const
    {
        Q_UNUSED(column)
        Q_UNUSED(action)
        if(!data->formats().contains("pintreemodel/item")) return false;
 
        QString type; int id;
        auto encItem = data->data("pintreemodel/item");
        QDataStream dataStream(&encItem, QIODevice::ReadOnly);
        dataStream >> type >> id;
        auto parentItem = static_cast<PortTreeItem*>(getItemFromIndex(parent));
     //   qDebug() << "type: " << type << ", id" << id << ", row: " << row;
 
        // construct a "drop-matrix" here, but only 4(5) things are NOT allowed (so check for these):
        // 1: drop a pin on its OWN parent
        // 3: drop a pingroup on/between pins
        // 4: drop an item on itself
        // 5: drop adjecent index to itself, must be at least 1 item apart
        if(type == "group")
        {
            auto item = static_cast<PortTreeItem*>(mIdToGroupItem[id]);
            if(parentItem)
            {
                if(item->itemType() == PortTreeItem::Pin || (item->itemType() == PortTreeItem::Group && row != -1) || item == parentItem)
                    return false;
            }
            else // here, only check for adjacent rows
            {
                auto itRow =  item->getOwnRow();
                if(itRow == row || ((itRow+1) == row))
                    return false;
            }
        }
        if(type == "pin")
        {
            // perhaps check here that a pin can only be dropped between groups if its own group has size > 1?
            // otherwise it does not make much sense...perhaps change this check
            auto item = mIdToPinItem[id];
            if((!parentItem && item->getParent()->getChildCount() == 1)
                || (item->getParent() == parentItem && row == -1)
                || item == parentItem )
               // || (parentItem && (parentItem->itemType() == PortTreeItem::Pin)))
                return false;
            // case if one wants to drop between pins in same group, check if its not adjacent row (other cases are handled on case above
            if(item->getParent() == parentItem)
            {
                auto itRow = item->getOwnRow();
                if(itRow == row || ((itRow+1) == row))
                    return false;
            }
        }
        return true;
    }
 
    void ModulePinsTreeModel::clear()
    {
        BaseTreeModel::clear();
        mModule = nullptr;
        mNameToTreeItem.clear();
        mIdToGroupItem.clear();
        mIdToPinItem.clear();
    }
 
    void ModulePinsTreeModel::setModule(Module* m)
    {
        mModule = m;
        beginResetModel();
 
        for(PinGroup<ModulePin>* pinGroup : m->get_pin_groups())
        {
            if(pinGroup->empty())
                continue;
 
            auto pinGroupName = QString::fromStdString(pinGroup->get_name());
            PortTreeItem* pinGroupItem = new PortTreeItem(PortTreeItem::Group, pinGroup->get_id(), pinGroupName, pinGroup->get_direction(),
                                                          pinGroup->get_type(), pinGroup->is_ascending() ? 0 : 1);
            mIdToGroupItem.insert(pinGroup->get_id(), pinGroupItem);
            for(ModulePin* pin : pinGroup->get_pins())
            {
                PortTreeItem* pinItem = new PortTreeItem(PortTreeItem::Pin,
                                                         pin->get_id(),
                                                         QString::fromStdString(pin->get_name()),
                                                         pin->get_direction(),
                                                         pin->get_type(),
                                                         pin->get_group().second,
                                                         QString::fromStdString(pin->get_net()->get_name()));
                pinGroupItem->appendChild(pinItem);
                mNameToTreeItem.insert(QString::fromStdString(pin->get_name()), pinItem);
                mIdToPinItem.insert(pin->get_id(), pinItem);
            }
            mNameToTreeItem.insert(pinGroupName, pinGroupItem);
            mRootItem->appendChild(pinGroupItem);
        }
 
//        for (PinGroup<ModulePin>* pinGroup : m->get_pin_groups())
//        {
//            //ignore empty pingroups
//            if (pinGroup->empty())
//                continue;
 
 
//            ModulePin* firstPin = pinGroup->get_pins().front();
//            QString pinGroupName;
//            QString pinGroupDirection = QString::fromStdString(enum_to_string(firstPin->get_direction()));
//            QString pinGroupType      = QString::fromStdString(enum_to_string(firstPin->get_type()));
//            if (pinGroup->size() == 1)
//            {
//                pinGroupName = QString::fromStdString(firstPin->get_name());
//            }
//            else
//            {
//                pinGroupName = QString::fromStdString(pinGroup->get_name());
//            }
 
//            TreeItem* pinGroupItem = new TreeItem(QList<QVariant>() << pinGroupName << pinGroupDirection << pinGroupType << "");
 
//            if (pinGroup->size() == 1)
//            {
//                pinGroupItem->setDataAtIndex(sNetColumn, QString::fromStdString(firstPin->get_net()->get_name()));
//                pinGroupItem->setAdditionalData(keyType, QVariant::fromValue(itemType::pin));
//                //since a single-pin pingroup represents the pin itself, take the pinid
//                pinGroupItem->setAdditionalData(keyId, firstPin->get_id());
//                mIdToPinItem.insert(firstPin->get_id(), pinGroupItem);
//            }
//            else
//            {
//                pinGroupItem->setAdditionalData(keyType, QVariant::fromValue(itemType::portMultiBit));
//                pinGroupItem->setAdditionalData(keyId, pinGroup->get_id());
//                mIdToGroupItem.insert(pinGroup->get_id(), pinGroupItem);
//                for (ModulePin* pin : pinGroup->get_pins())
//                {
//                    TreeItem* pinItem =
//                        new TreeItem(QList<QVariant>() << QString::fromStdString(pin->get_name()) << pinGroupDirection << pinGroupType << QString::fromStdString(pin->get_net()->get_name()));
//                    pinItem->setAdditionalData(keyType, QVariant::fromValue(itemType::pin));
//                    pinItem->setAdditionalData(keyId, pin->get_id());
//                    pinGroupItem->appendChild(pinItem);
//                    mNameToTreeItem.insert(QString::fromStdString(pin->get_name()), pinItem);
//                    mIdToPinItem.insert(pin->get_id(), pinItem);
//                }
//            }
//            mRootItem->appendChild(pinGroupItem);
//            mNameToTreeItem.insert(pinGroupName, pinGroupItem);
//        }
        endResetModel();
 
        Q_EMIT numberOfPortsChanged(m->get_pins().size());
    }
 
    Net* ModulePinsTreeModel::getNetFromItem(PortTreeItem* item)
    {
        if (!mModule)    //no current module = no represented net
            return nullptr;
 
        if (item->itemType() == PortTreeItem::Group && item->getChildCount() > 1)
            return nullptr;
 
        Module* m = gNetlist->get_module_by_id(mModule->get_id());
        if (!m)
            return nullptr;
 
        //std::string name = item->getData(sNameColumn).toString().toStdString();
        if (auto* pin = m->get_pin_by_id(item->id()); pin != nullptr)
        {
            return pin->get_net();
        }
 
        return nullptr;
    }
 
    int ModulePinsTreeModel::getRepresentedModuleId()
    {
        if (!mModule) return -1;
        return mModule->get_id();
    }
 
    void ModulePinsTreeModel::handleModulePortsChanged(Module* m, PinEvent pev, u32 pgid)
    {
        static const QSet<PinEvent> groupEvents = {   PinEvent::GroupCreate,
                                                      PinEvent::GroupReorder,
                                                      PinEvent::GroupRename,
                                                      PinEvent::GroupTypeChange,
                                                      PinEvent::GroupDirChange,
                                                      PinEvent::GroupDelete};
        Q_UNUSED(pev);
        Q_UNUSED(pgid);
        if (m != mModule) return;
 
        // debug pingroups  log_info("gui", "Handle pin_changed event {} ID={}", enum_to_string<PinEvent>(pev), pgid);
        PortTreeItem* ptiPin = nullptr;
        PortTreeItem* ptiGroup = nullptr;
        const PinGroup<ModulePin>* pgroup = nullptr;
        const ModulePin* pin = nullptr;
        int pinRow = -1;
 
 
        if (groupEvents.contains(pev))
        {
            // group event
            ptiGroup = mIdToGroupItem.value(pgid);
            if (pev != PinEvent::GroupCreate && !ptiGroup)
            {
                log_warning("gui", "Cannot handle event for pin group ID={}, tree item does not exist.", pgid);
                return;
            }
            if (pev != PinEvent::GroupDelete)
            {
                pgroup = m->get_pin_group_by_id(pgid);
                if (!pgroup)
                {
                    log_warning("gui", "Cannot handle event for pin group ID={}, no such group.", pgid);
                    return;
                }
            }
        }
        else
        {
            // pin event
            ptiPin = mIdToPinItem.value(pgid);
            if (pev != PinEvent::PinCreate && !ptiPin)
            {
                log_warning("gui", "Cannot handle event for pin ID={}, tree item does not exist.", pgid);
                return;
            }
            if (pev != PinEvent::PinDelete)
            {
                pin = m->get_pin_by_id(pgid);
                if (!pin)
                {
                    log_warning("gui", "Cannot handle event for pin ID={}, no such pid.", pgid);
                    return;
                }
                auto pgPair = pin->get_group();
                pgroup = pgPair.first;
                pinRow = pinIndex2Row(pin,pgPair.second);
                if (pgroup)
                    ptiGroup = mIdToGroupItem.value(pgroup->get_id());
            }
        }
 
        QModelIndex dataChangedIndex;
 
        switch (pev)
        {
        case PinEvent::GroupCreate:
        {
            ptiGroup = new PortTreeItem(PortTreeItem::Group,
                                        pgroup->get_id(),
                                    QString::fromStdString(pgroup->get_name()),
                                    pgroup->get_direction(),
                                    pgroup->get_type(),
                                    pgroup->is_ascending()?0:1);
            mIdToGroupItem.insert(ptiGroup->id(), ptiGroup);
            int inx = pinGroupIndex(m,pgroup);
            insertItem(ptiGroup, mRootItem, inx);
            break;
        }
        case PinEvent::GroupReorder:
        {
            int inx = pinGroupIndex(m,pgroup);
            removeItem(ptiGroup);
            insertItem(ptiGroup, mRootItem, inx);
            break;
        }
        case PinEvent::GroupRename:
            ptiGroup->setName(QString::fromStdString(pgroup->get_name()));
            dataChangedIndex = getIndexFromItem(ptiGroup);
            break;
        case PinEvent::GroupTypeChange:
            ptiGroup->setPinType(pgroup->get_type());
            dataChangedIndex = getIndexFromItem(ptiGroup);
            break;
        case PinEvent::GroupDirChange:
            ptiGroup->setPinDirection(pgroup->get_direction());
            dataChangedIndex = getIndexFromItem(ptiGroup);
            break;
        case PinEvent::GroupDelete:
            removeItem(ptiGroup);
            delete ptiGroup;
            break;
        case PinEvent::PinCreate:
        {
            if (!pgroup || !ptiGroup)
            {
                log_warning("gui", "Cannot handle pin create event for pin ID={}, pin is not assigned to any group.", pgid);
                return;
            }
            QString netName;
            if (pin->get_net())
                netName = QString::fromStdString(pin->get_net()->get_name());
            ptiPin = new PortTreeItem(PortTreeItem::Pin,
                                      pin->get_id(),
                                   QString::fromStdString(pin->get_name()),
                                   pin->get_direction(),
                                   pin->get_type(),
                                   pin->get_group().second,
                                   netName);
            mIdToPinItem.insert(ptiPin->id(), ptiPin);
            insertItem(ptiPin, ptiGroup, pinRow);
            updateGroupIndex(ptiGroup);
            break;
        }
        case PinEvent::PinReorder:
        {
            if (!pgroup || !ptiGroup)
            {
                log_warning("gui", "Cannot handle pin reorder event for pin ID={}, pin is not assigned to any group.", pgid);
                return;
            }
            removeItem(ptiPin);
            insertItem(ptiPin, ptiGroup, pinRow);
            updateGroupIndex(ptiGroup);
            break;
        }
        case PinEvent::PinAssignToGroup:
        {
            if (!pgroup || !ptiGroup)
            {
                log_warning("gui", "Cannot handle pin assign event for pin ID={}, pin is not assigned to any group.", pgid);
                return;
            }
            removeItem(ptiPin);
            insertItem(ptiPin, ptiGroup, pinRow);
            updateGroupIndex(ptiGroup);
            break;
        }
        case PinEvent::PinRename:
            ptiPin->setName(QString::fromStdString(pin->get_name()));
            dataChangedIndex = getIndexFromItem(ptiPin);
            break;
        case PinEvent::PinTypeChange:
            ptiPin->setPinType(pin->get_type());
            dataChangedIndex = getIndexFromItem(ptiPin);
            break;
        case PinEvent::PinDirChange:
            ptiPin->setPinDirection(pin->get_direction());
            dataChangedIndex = getIndexFromItem(ptiPin);
            break;
        case PinEvent::PinDelete:
            removeItem(ptiPin);
            delete ptiPin;
            break;
        default:
            break;
        }
 
        if (dataChangedIndex.isValid())
        {
            QModelIndex inxLastCol = createIndex(dataChangedIndex.row(),columnCount()-1,dataChangedIndex.internalPointer());
            Q_EMIT dataChanged(dataChangedIndex,inxLastCol);
        }
    }
 
    void ModulePinsTreeModel::dndGroupOnGroup(BaseTreeItem *droppedGroup, BaseTreeItem *onDroppedGroup, int row)
    {
        // SPECIFY: 1) create completely new group, all pins in that, delete old 2 groups
        // 2) just add all pins from dropped group to "ondroppedgroup", then rename?
//        InputDialog ipd("Name of new group", "Name of new group:", onDroppedGroup->getData(sNameColumn).toString());
//        if(ipd.exec() == QDialog::Rejected) return false;
        QList<u32> pins;
        auto srcgroup = mModule->get_pin_group_by_id(static_cast<PortTreeItem*>(droppedGroup)->id());
        for(const auto &pin : srcgroup->get_pins())
            pins.append(pin->get_id());
        if (pins.isEmpty()) return;  // no pins to move
 
        auto tgtgroup = mModule->get_pin_group_by_id(static_cast<PortTreeItem*>(onDroppedGroup)->id());
 
        ActionPingroup* act = ActionPingroup::addPinsToExistingGroup(mModule,tgtgroup->get_id(),pins,row);
        if (act) act->exec();
 
        // too keep the order, ActionAddItemsToObject cannot be executed with all pins, but a ComAction must be created
        // with many ActionAddItemsToObject that contain a single pin each -> set destroys order of pins in source pingroup
    }
 
    void ModulePinsTreeModel::dndGroupBetweenGroup(PortTreeItem *droppedGroup, int row)
    {
        int ownRow = droppedGroup->getOwnRow();
        bool bottomEdge = row == mRootItem->getChildCount();
        auto desiredIdx = bottomEdge ? row-1 : row;
        if(ownRow < row && !bottomEdge) desiredIdx--;
        ActionPingroup* act = new ActionPingroup(PinActionType::GroupMoveToRow,droppedGroup->id(),"",desiredIdx);
        act->setObject(UserActionObject(mModule->get_id(),UserActionObjectType::Module));
        act->exec();
    }
 
    void ModulePinsTreeModel::dndPinOnGroup(PortTreeItem *droppedPin, BaseTreeItem *onDroppedGroup)
    {
        ActionPingroup* act = new ActionPingroup(PinActionType::PinAsignToGroup,droppedPin->id(),"",static_cast<PortTreeItem*>(onDroppedGroup)->id());
        act->setObject(UserActionObject(mModule->get_id(),UserActionObjectType::Module));
        act->exec();
    }
 
    void ModulePinsTreeModel::dndPinBetweenPin(PortTreeItem *droppedPin, BaseTreeItem *onDroppedParent, int row)
    {
        int desiredIdx = row;
        ActionPingroup* act = nullptr;
        if(droppedPin->getParent() == onDroppedParent) // same group
        {
            int ownRow = droppedPin->getOwnRow();
            bool bottomEdge = row == onDroppedParent->getChildCount();
            desiredIdx = bottomEdge ? row-1 : row;
            if(ownRow < row && !bottomEdge) desiredIdx--; // insert item here
            act = new ActionPingroup(PinActionType::PinMoveToRow,droppedPin->id(),"",desiredIdx);  // TODO : start_index, descending
        }
        else
        {
            act = ActionPingroup::addPinToExistingGroup(mModule,static_cast<PortTreeItem*>(onDroppedParent)->id(),droppedPin->id(),desiredIdx);
            if (!act) return;
        }
        act->setObject(UserActionObject(mModule->get_id(),UserActionObjectType::Module));
        act->exec();
    }
 
    void ModulePinsTreeModel::dndPinBetweenGroup(PortTreeItem *droppedPin, int row)
    {
        // row is needed for when groups can change its order within the module
        Q_UNUSED(row)
 
        auto pinToMove = mModule->get_pin_by_id(droppedPin->id());
        if (!pinToMove) return;
 
        QString groupName = generateGroupName(mModule,pinToMove);
 
        ActionPingroup* act = ActionPingroup::addPinToNewGroup(mModule, groupName, droppedPin->id(),row);
        act->exec();
    }
 
    void ModulePinsTreeModel::updateGroupIndex(PortTreeItem* groupItem)
    {
        PinGroup<ModulePin>* pg = mModule->get_pin_group_by_id(groupItem->id());
        Q_ASSERT(pg);
        for (ModulePin* pin : pg->get_pins())
        {
            int inx = pg->get_index(pin).get();
            PortTreeItem* pinItem = mIdToPinItem.value(pin->get_id());
            Q_ASSERT(pinItem);
            pinItem->setIndex(inx);
        }
        QModelIndex pi = getIndexFromItem(groupItem);
        QModelIndex i0 = index(0,0,pi);
        QModelIndex i1 = index(groupItem->getChildCount()-1,4,pi);
        Q_EMIT dataChanged(i0,i1);
    }
 
    void ModulePinsTreeModel::insertItem(PortTreeItem* item, BaseTreeItem* parent, int index)
    {
        // fun fact: if an item is inserted above an item that is expanded, the tree collapses all indeces
        beginInsertRows(getIndexFromItem(parent), index, index);
        parent->insertChild(index, item);
        endInsertRows();
        //mNameToTreeItem.insert(item->getData(sNameColumn).toString(), item);
        item->itemType() == PortTreeItem::Pin ? mIdToPinItem.insert(item->id(), item) : mIdToGroupItem.insert(item->id(), item);
        //mIdToPinItem.insert(getIdOfItem(item), item);
    }
 
    void ModulePinsTreeModel::removeItem(PortTreeItem* item)
    {
        beginRemoveRows(parent(getIndexFromItem(item)), item->getOwnRow(), item->getOwnRow());
        item->getParent()->removeChild(item);
        endRemoveRows();
        //mNameToTreeItem.remove(item->getData(sNameColumn).toString());
        //for now, only ids of pin-items (since these functions are only relevant for dnd)
        item->itemType() == PortTreeItem::Pin ? mIdToPinItem.remove(item->id()) : mIdToGroupItem.remove(item->id());
        //mIdToPinItem.remove(getIdOfItem(item));
        //delete item;
    }
 
 
 
}    // namespace hal